Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLAlchemy update 1.4 -> 2.0 #43

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

SQLAlchemy update 1.4 -> 2.0 #43

wants to merge 37 commits into from

Conversation

teald
Copy link
Member

@teald teald commented Jul 10, 2024

Resolves issue #39

Status

This currently passes:

  • code_tests ✅

It will require more testing before being merged in.

Changes

  • Followed migration guide to update SQLAlchemy to use the v2 API (see SQLAlchemy 1.4 -> 2.0 Update #39).
  • Updates requirements.txt
  • (❓) Add code testing with nox
  • (❓) Add requirement_dev.txt (contains some top-level, non-development dependencies at the moment)

❓-> Added, but can be removed before merging. These are for my own convenience.

Migration info/todo

See Issue #39 for details.

teald added 28 commits July 10, 2024 14:11
@teald
Update declarative_base to come from sqlalchemy orm.
9e918dc
@teald
Change sqlalchemy.ext -> sqlalchemy.orm
7e61902
@teald
session.query.get deprecated
6e320b0 
Instead, it is accessed through session.get(to_be_queried, key).
@teald
declarative_base update in db __init__
224a38f
@teald
Adding nox file and add dev requirements.
eb19f6c
@teald
Updates to querying tables.
1b6595f
@teald
Add engine check
8e21c2b
@teald
Add checks for create_engine without future=True
7115a8f
@teald
Add todo to noxfile
e7a48dd
@teald
Add regex for sessionfactory
aae39cf
@teald
update environment variables and add comments for sessions
5fef0a7
@teald
Update to ensure RemovedIn20Warnings are raised correctly.
713cfc4
@teald
Fir RemovedIn20Warning handling by nox.
7fcc022
@teald
Add RemovedIn20Warnings as errors in nox tests.
258a4fb
@teald
Use declarative_base from orm.
234a09d
@teald
Change relation->relationship (naively)
a588aa0 
Changes most of the `relation` calls to `relationship` calls per the
warning messages. However, this causes at least one error due to a
nuance in how `relation` works, it seems, and that needs to be
diagnosed.
@teald
[NOT SQL] Add error message to exception capture.
377e57e 
This non-sql related update catches the base exception caught in
FileOpser.fileop and adds its message to the FileOpser.doerror message.

This is mainly for convenience with updating, and can be omitted later
if desired.
@teald
session.query.get -> session.get
168f55d
@teald
Remove unused relation (deprecated) import
bf7b1c1
@teald
Update relation check in noxfile + replacement.
cda0329
@teald
Further update session.query.get -> session.get
ab4648f
@teald
Add future=True to create_engine
6c70192
@teald
String literals -> raw strings for regex
84ec999
@teald
Add future=True to sessionmaker.
173431f
@teald
Add derivative _Base class with __allow_unmapped__ = True
9796a34 
This overrides SQLAlchemy's declarative_base in both instances when
creating the declarative base class.
@teald
Upgrade SQLAlchemy to v2.0
4c3c943
@teald
Linting noxfile (nothing else).
e935f66
@teald
Add noxfile lint to standard run.
647d39b
@teald teald added the enhancement New feature or request label Jul 10, 2024
@teald teald requested a review from phirstgemini July 10, 2024 21:21
@teald teald linked an issue Jul 10, 2024 that may be closed by this pull request
SQLAlchemy 1.4 -> 2.0 Update #39
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phirstgemini phirstgemini Awaiting requested review from phirstgemini

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLAlchemy 1.4 -> 2.0 Update
2 participants
@teald @phirstgemini