Implement blank_none option, satisfying #35 #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Changes being made
Give examples of the changes you've made in this pull request. Include an itemized list if you can.
FPV_BLANK_NONE
configuration option, which is handled asFalse
if not setblank_none
parameter toParameter
constructor, which defaults toFPV_BLANK_NONE
if not set, determines if an empty string passed to anOptional[str]
parameter will be converted toNone
Optional
, as implementingblank_none
broke the existing implementation🧠 Rationale behind the change
Why did you choose to make these changes?
null
in place of an empty string, so this option could help those developers use this library more smoothlyDoes this pull request resolve any open issues?
Closes #35
Were there any trade-offs you had to consider?
🧪 Testing
[ X ] Have tests been added or updated for the changes introduced in this pull request?
[ X ] Are the changes backwards compatible?
If the changes aren't backwards compatible, what other options were explored?
✨ Quality check
[ X ] Are your changes free of any erroneous print statements, debuggers or other leftover code?
[ X ] Has the README been updated to reflect the changes introduced (if applicable)?
💬 Additional comments