Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beamline fixes 4 #3504

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Beamline fixes 4 #3504

wants to merge 32 commits into from

Conversation

Elisis
Copy link
Member

@Elisis Elisis commented Nov 16, 2024

Additions

  • Adds hot super coolant fluid for Synchrotron and LINAC coolant output, can be cooled back to regular super coolant in VF
  • Add Prepared Masks for CPU, NCPU, PIC, HPIC. CR mask-to-mask recipes are replaced with mask-to-prepared mask, and prepared mask-to-mask engraver recipes are added. E.g. CPU-(CR)->PrCPU-(PLE)->NCPU.
  • Adds beamline recipes for crystal chips, along with associated masks.

Balancing

  • Reduces UHPIC minimum TC energy to 190eV.
  • Adds subticking to TC.
  • TC recipe time save per increase in wafer tier improved by ~20%
  • Synchrotron allowed to use laser/multiamp energy hatches.

Fixes

  • Fixes LINAC energy handling, now takes full amperage with two energy hatches.
  • Fixes TC IOOB exception caused by empty focus input bus.
  • Makes NPIC max energy sane.
  • Increases LINAC coolant usage, now equal to length kL/s.
  • Fixes OBOE with focus durability vs. max uses.
  • Fixes equal amount values across different wafer tiers in TC recipes.
  • Fixes tricoder NPEing on all multis that don't yet have beamline input hatches.
  • Fixes empty Reactive-Ion Etching Mixture centrifuge recipe

QoL

  • Adds max number of uses of foci to their tooltips.
  • Casing and item textures updated (Credit goes to BlueHero233)

Elisis and others added 21 commits October 7, 2024 17:51
…fixes-4

# Conflicts:
#	src/main/resources/assets/gtnhlanth/textures/items/photomask/cblank.png
#	src/main/resources/assets/gtnhlanth/textures/items/photomask/ccpu.png
@Elisis Elisis added enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. Affects Balance Change affecting balance. Requires admin approval before merging. bug fix Fix a bug. Please link it in the PR. labels Nov 16, 2024
@boubou19 boubou19 added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 16, 2024
@Dream-Master
Copy link
Member

@boubou19 if it contain more fixes than changes I would add it to 2.7 . Thoughts ?

@Dream-Master Dream-Master requested a review from a team November 16, 2024 13:53
@FireWarrior2
Copy link
Contributor

@Elisis this one also will be nice if fixed GTNewHorizons/GT-New-Horizons-Modpack#17710

@Ruling-0
Copy link
Contributor

@boubou19 if it contain more fixes than changes I would add it to 2.7 . Thoughts ?

This really should get in - these are some pretty important fixes and balance changes.

@Elisis
Copy link
Member Author

Elisis commented Nov 17, 2024

@Elisis this one also will be nice if fixed GTNewHorizons/GT-New-Horizons-Modpack#17710

Ah, that was the IOOB I mentioned

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 18, 2024
Copy link
Contributor

Warning: 2 uncommitted changes
#3523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. bug fix Fix a bug. Please link it in the PR. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants