Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EHE info and buff lava in EHE #3494

Merged
merged 4 commits into from
Nov 16, 2024

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Nov 14, 2024

  1. Buff lava and make it produce sc and sh steam instead of sh steam and regular steam
    8x more lava throughput (20k -> 160k)
    image
    Closes Balance Extreme Heat Exchanger to be Better then Whakawhati GT-New-Horizons-Modpack#14517

  2. Add structure blocks to structure tooltip list
    image
    as part of Wrong Industrial Precision Lathe tooltip GT-New-Horizons-Modpack#17847

  3. Adds more description to explain how EHE works
    image

  4. Removes threshold with plasma input and removes overheat water input since with the removal of steam from lava, all recipes uses the same amount of water regardless if its normal or overheated
    image

@Dream-Master Dream-Master added the bug fix Fix a bug. Please link it in the PR. label Nov 14, 2024
@Dream-Master Dream-Master requested a review from a team November 14, 2024 15:03
@FireWarrior2
Copy link
Contributor

Can string "Max Distilled Water Input(Overheated):" be also fixed not to get out from window?
For example, make something like:
Max Distilled Water:
Normal - 20,000 L/s
Overheated - 20,000 L/s
This will also probably make Threshold string not get on next recipe (4 strings - > 3 strings).

@StaffiX
Copy link
Contributor Author

StaffiX commented Nov 14, 2024

kép
well I tried but it looks confusing with the threshold, and this doesn't really help with lack of EHE's documentation.
My issue is that this way, it doesnt really look like that line 1, 2 and 5 are separate, while line 3, 4 and 5 are connected

@FireWarrior2
Copy link
Contributor

FireWarrior2 commented Nov 14, 2024

Just move threshold after hot fluid input.
Maybe rename it to "Hot Fluid Threshold"
Documentation can be added in quest.

@StaffiX StaffiX marked this pull request as draft November 14, 2024 21:09
@FireWarrior2
Copy link
Contributor

Maybe you also fix EHE tooltip?
GTNewHorizons/GT-New-Horizons-Modpack#17847

@StaffiX StaffiX changed the title Fix EHE NEI page (again) Improve EHE info and buff lava in EHE Nov 16, 2024
@StaffiX StaffiX marked this pull request as ready for review November 16, 2024 17:44
@StaffiX
Copy link
Contributor Author

StaffiX commented Nov 16, 2024

This ended up being more than just a simple bug fix

@serenibyss serenibyss added the Affects Balance Change affecting balance. Requires admin approval before merging. label Nov 16, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) November 16, 2024 18:03
@Dream-Master Dream-Master merged commit 04e037f into GTNewHorizons:master Nov 16, 2024
5 checks passed
@StaffiX StaffiX deleted the ehefix branch November 16, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance Extreme Heat Exchanger to be Better then Whakawhati
4 participants