Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix essentia search NPE #26

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix essentia search NPE #26

merged 2 commits into from
Nov 19, 2024

Conversation

wlhlm
Copy link
Member

@wlhlm wlhlm commented Nov 19, 2024

@slprime
Copy link
Member

slprime commented Nov 19, 2024

@wlhlm why in draft? it fixed bug

How to check: add "Enchanted Fabric" in chest and try find it

@wlhlm
Copy link
Member Author

wlhlm commented Nov 19, 2024

I actually wasn't able to reproduce the crash, so I'm currently waiting for the reporters to confirm.

@slprime
Copy link
Member

slprime commented Nov 19, 2024

I actually wasn't able to reproduce the crash, so I'm currently waiting for the reporters to confirm.

Add "Phial of Essentia" and "Enchanted Fabric" in chest and try find "Enchanted Fabric"

@wlhlm
Copy link
Member Author

wlhlm commented Nov 19, 2024

Yep, thanks for the guide. I can reproduce now and this PR fixes it.

@wlhlm wlhlm marked this pull request as ready for review November 19, 2024 17:10
@Dream-Master Dream-Master merged commit d78625b into master Nov 19, 2024
1 check passed
@Dream-Master Dream-Master deleted the fix-essentia-search-npe branch November 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants