feat: add configuration option to disable empty item stack highlighting #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miozune
reviewed
Sep 27, 2024
|
Applied the changes, thanks for the review! |
miozune
reviewed
Sep 27, 2024
miozune
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another QoL update. I noticed that the item highlight feature also highlights items inside of storage drawers if their stack size is 0. This usually happens if you lock the items using the key and remove all of them.
The PR adds a new configuration option that can be set to true to restore the old behavior. The new behavior does not highlight inventories that contain item stacks of size zero.
The behavior before the change. The inventory was highlighted and its stack size is zero:
Having the config key set to false blocks the application of the highlight:
