Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing team section #109

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Landing team section #109

wants to merge 16 commits into from

Conversation

RamyAlshurafa
Copy link
Member

@RamyAlshurafa RamyAlshurafa commented Dec 30, 2018 •
edited
Loading

Relates #43

  • move the store into a separated file.
  • create Team section for LandingPage layout.
  • create team reducer.
  • create fetch team action.
  • test Team section component.
  • update failed the test for TeamCard

@RamyAlshurafa RamyAlshurafa changed the title [WiP] Landing team section Landing team section Jan 2, 2019
@RamyAlshurafa RamyAlshurafa self-assigned this Jan 2, 2019
@RamyAlshurafa RamyAlshurafa added this to the Landing Page milestone Jan 2, 2019
FarahZaqout
FarahZaqout reviewed Jan 6, 2019
View reviewed changes
Copy link
Member

@FarahZaqout FarahZaqout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo I need you to visit gsg, sometime this week because i'm a piece of shit with 60 pages in the book to read and I won't be able to read redux anytme soon.

client/src/actions/fetch_team_members.js
@@ -0,0 +1,11 @@
import axios from 'axios';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need axios? I don't know how useful it is to be honest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this https://medium.com/@sahilkkrazy/fetch-vs-axios-http-request-c9afa43f804e. please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amusameh amusameh Awaiting requested review from amusameh

@ashatat ashatat Awaiting requested review from ashatat

@FarahZaqout FarahZaqout Awaiting requested review from FarahZaqout

Assignees

@RamyAlshurafa RamyAlshurafa

Labels
awaiting-review
Projects
None yet
Milestone
Landing Page
Development

Successfully merging this pull request may close these issues.
3 participants
@RamyAlshurafa @ashatat @FarahZaqout