Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/all valid test #896

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Feature/all valid test #896

wants to merge 20 commits into from

Conversation

wandmagic
Copy link
Collaborator

@wandmagic wandmagic commented Nov 13, 2024 •
edited
Loading

Committer Notes

Provides an extra test for all valid documents which we can add to. IE fedramp tamples awesome cloud etc...

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic wandmagic requested a review from a team as a code owner November 13, 2024 15:23
aj-stein-gsa
aj-stein-gsa requested changes Nov 14, 2024
View reviewed changes
features/fedramp_extensions.feature Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/validations/module.mk Outdated Show resolved Hide resolved
@aj-stein-gsa aj-stein-gsa added devops type: backlog item For developer work that is not part of a user-facing epic or user story. scope: constraints labels Nov 14, 2024
wandmagic and others added 2 commits November 14, 2024 00:26
@wandmagic @aj-stein-gsa
Update fedramp_extensions.feature
03e79c2 
Co-authored-by: A.J. Stein <[email protected]>
@wandmagic @aj-stein-gsa
Update module.mk
98fcff0 
Co-authored-by: A.J. Stein <[email protected]>
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 14, 2024
View reviewed changes
package.json Show resolved Hide resolved
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 14, 2024
View reviewed changes
aj-stein-gsa
aj-stein-gsa requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase and not merge commits? They will block changes on feature branches.

@aj-stein-gsa aj-stein-gsa requested review from Gabeblis and a team November 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-gsa aj-stein-gsa aj-stein-gsa approved these changes

@Gabeblis Gabeblis Awaiting requested review from Gabeblis

Requested changes must be addressed to merge this pull request.

Assignees

@wandmagic wandmagic

Labels
devops scope: constraints type: backlog item For developer work that is not part of a user-facing epic or user story.
Projects
FedRAMP Automation
Status: 👀 In review
Milestone
Digital Authorization Phase 1
Development

Successfully merging this pull request may close these issues.
3 participants
@wandmagic @Gabeblis @aj-stein-gsa