Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR to formally deprecate Spock versioning, formalize Semantic Versioning Use #866

Merged

Conversation

aj-stein-gsa
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa commented Nov 5, 2024

Committer Notes

This is a PR to backport a previously made decision in previous implementer meetings in the Automation Team. We need to complete this as part of #847, along with website documentation, to properly inform the requirements in #833.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa force-pushed the 847-adr-deprecate-spock-now-semver branch from edb41f2 to e1283d3 Compare November 6, 2024 00:41
@aj-stein-gsa aj-stein-gsa marked this pull request as ready for review November 6, 2024 00:57
@aj-stein-gsa aj-stein-gsa requested a review from a team as a code owner November 6, 2024 00:57
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aj-stein-gsa looks good overall. Just a couple of minor suggestions.

documents/adr/0010-semantic-versions-only.md Outdated Show resolved Hide resolved
documents/adr/0010-semantic-versions-only.md Show resolved Hide resolved
@aj-stein-gsa aj-stein-gsa merged commit e3b9676 into GSA:develop Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants