Startup script change #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isopod00
approved these changes
Nov 8, 2024
|
This won't check for updates automatically, which may be problematic. The build script does |
|
the build script doesnt see changes anyways. It finds cached image and builds that instead. you have to manually disable the search for cached image before build_immage works. It could also be that you manually run build_image to update image |
|
All good then, just didn't want a degredation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated enter_isaac_ros_container script to check if the image already exists before trying to build it from scratch. Running build_image.sh everytime takes substantially longer than checking to see if we need to build it vs just opening the container.