Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve document symbol hierarchy to match rust-analyzer layout #6678

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoshuaBatty
Copy link
Member

Description

Changes document symbols to show the nested outline of a file with type information, matching rust-analyzer's outline view structure.

closes #6100

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty requested a review from a team as a code owner October 30, 2024 04:47
@JoshuaBatty JoshuaBatty self-assigned this Oct 30, 2024
@JoshuaBatty JoshuaBatty added enhancement New feature or request language server LSP server labels Oct 30, 2024
@JoshuaBatty JoshuaBatty marked this pull request as draft October 30, 2024 04:48
@alfiedotwtf
Copy link
Contributor

Just curious why both range and selection_range are needed if they're the same values?

@JoshuaBatty
Copy link
Member Author

Just curious why both range and selection_range are needed if they're the same values?

I just put that there as a placeholder for now, still need to sort that and quite a bit more out. Probably at least a few more days of work left to get this PR ready. I'd expect this part to change before i'm ready to open up the PR for review.

@maxtalantsev
Copy link

cool

@FuelLabs FuelLabs deleted a comment from maxtalantsev Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request language server LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested outline of file for LSP
3 participants