Added QueueJob RunUntilEmptyAsync TimeSpan Overload, refactored cancellation tokens #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemyjski
commented
Jul 19, 2024
| linkedCancellationTokenSource.CancelAfter(acquireTimeout); | ||
|
|
||
| // NOTE: This has to be awaited otherwise the linkedCancellationTokenSource cancel timer will not fire. | ||
| await job.RunUntilEmptyAsync(linkedCancellationTokenSource.Token); |
There was a problem hiding this comment.
NOTE: this was initially just returning the task, which did not dispose of the cancellation token but DID prevent the cancellation token timer from firing.... This was a huge time sink to track down.
There was a problem hiding this comment.
niemyjski
commented
Jul 19, 2024
| using (var timeoutCancellationTokenSource = new CancellationTokenSource(30000)) | ||
| using (var linkedCancellationToken = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken, timeoutCancellationTokenSource.Token)) | ||
| using var linkedCancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken); | ||
| linkedCancellationTokenSource.CancelAfter(TimeSpan.FromSeconds(30)); |
There was a problem hiding this comment.
This seems more explicit about the behaviors and scoping of parent tokens.
ejsmith
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should generally speed up tests where you don't want to wait the full 30 second default timeout.