Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-FGTMonitorSystemConfigBackup: Add scope vdom #272

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johan-kummeneje-complior
Copy link

@johan-kummeneje-complior johan-kummeneje-complior commented Oct 14, 2024

Fixing issue #271

Fixing issue 271
@alagoutte alagoutte changed the title Update backup.ps1 Get-FGTMonitorSystemConfigBackup: Add scope vdom Oct 15, 2024
@alagoutte
Copy link
Contributor

Hi Johan,

May be a better to add -scope parameter ? because if you are using vdom but you want to have a global config...

@johan-kummeneje-complior
Copy link
Author

Hi Alexis,
it really doesn't make sense to want the global config and passing a vdom as argument.
Doing so just gives you the full config anyways. If one wants a vdom, just pass the vdom as argument.

Best Regards
Johan

@alagoutte
Copy link
Contributor

you can use connect-fgt with directly vdom parameter and it is "store" but maybe you want to get global config....

@johan-kummeneje-complior
Copy link
Author

Ok, that should be possible to do. I will try to squeeze it in in the next few weeks.

Update accordingly with Alexis suggestion on scope param
@johan-kummeneje-complior
Copy link
Author

@alagoutte

I fixed the code so it works both automatically and also if needed you can put the scope parameter in.

Best Regards
Johan

@alagoutte
Copy link
Contributor

Hi Johan,

Thanks, i will try to look this week

}

#before 7.6.x, config/backup is available with get method and using paramater
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change comment ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not intentionally changed.

@@ -1,4 +1,4 @@
#
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange. they seem to be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants