-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding state function to multiwalker #1149
Adding state function to multiwalker #1149
Conversation
Awesome, have seen that issue up for a while thanks for the contribution Florian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But yeah I would honestly put this into the base env since multiwalker.py
's file structure basically mirrors other sisl environment's file structure, it's already calling self.env.x
so moving it into the base env makes more sense too.
@jjshoots done |
Looks good to me as well, cheers (and happy holidays) |
Description
I added a state method giving a global view of the env on multiwalker
Realtes to #323
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.