Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new maze environment #317

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

navpreetnp7
Copy link

@navpreetnp7 navpreetnp7 commented Feb 28, 2023

Description

Added a maze environment

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@jbloomAus
Copy link
Contributor

Navpreet and I were working on making a Maze environment for Minigrid which I'll finish shortly.

@pseudo-rnd-thoughts
Copy link
Member

@jbloomAus Could you provide a description of the environment?

@jbloomAus
Copy link
Contributor

@pseudo-rnd-thoughts Apologies for the delay. The environment (once I get around to or get someone to finish it) should essentially generate a perfect maze using Prim's algorithm. The task is a standard maze-solving task. I expect it to be solvable easily with a convolutional neural network and a fully observable wrapper but very challenging with a partial view.

I'm making a PR to track this and also add Kruskal's algorithm on my DecisionTransformerInterpretability Repo so feel free to stop tracking it here if you don't like the half-finished PR.

However, if you are opposed to this environment being added for any reason, then let me know, and I'll make sure not to bother you with the PR.

@pseudo-rnd-thoughts
Copy link
Member

Hi @jbloomAus that sounds interesting, could you add a figure with example mazes generated and some general performance measures for different training algorithms if possible

@navpreetnp7 navpreetnp7 marked this pull request as ready for review May 12, 2023 22:14
@pseudo-rnd-thoughts
Copy link
Member

@jbloomAus @navpreetnp7 Hey, would you be able to fix pre-commit (pre-commit run --all-files) and add a test that the maze generated are solvable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants