Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user to request new seasons of a already provided show #966

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ToMattBan
Copy link

Description

Follow the flow:

  • User "Bob" request "Vikings"
  • I complete the request by adding "Vikings" in the server
  • After 2 months, a new Vikings season is out
  • User "John" try to request the new season
  • No "Request" button is available

This PR aims to fix this, by adding a "Request More" button that allows the user to request a new season of the show.

Screenshot (if UI-related)

image

Issues Fixed or Closed

src/i18n/locale/pt_BR.json Outdated Show resolved Hide resolved
When a new season of a show already available launches, the users can't ask for the new season as
the request more button doesn't appear, this commit aims to fix this

Fallenbagel#962
@gauthier-th gauthier-th changed the title Allow user to request new seasons of a already provided show fix: allow user to request new seasons of a already provided show Sep 15, 2024
Comment on lines +295 to +302
} else if (
mediaType === 'tv' &&
hasPermission([Permission.REQUEST, Permission.REQUEST_TV], {
type: 'or',
}) &&
media &&
media.status === MediaStatus.PARTIALLY_AVAILABLE
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should merge this condition with the one below, both are doing the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

series: new seasons not requestable if older seasons already here
3 participants