Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace streaming providers' names with their equivalent logos #932

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JoaquinOlivero
Copy link
Contributor

Description

This PR changes the name of the different streaming services with their corresponding logos. The TMDB API provides the image URLs for the logos.
Also, a tooltip with the provider's name is shown when hovering over the logo.

Screenshot (if UI-related)

image
image

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with other external link images below, could you apply a hover transition to the images so that the opacity is set to 1 when they are hovered?

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Currently streaming on" to show the streamers' logos
2 participants