feat: remove requests of unmonitored movies/seasons during scan

[bonswouar]

Description

Quick & easy first implementation of Monitoring status support in Radarr:
When a movie - which was monitored before - is unmonitored, it won't appear as "requested" in Jellyseerr anymore

Issues Fixed or Closed

• Support monitor type for Radarr #695

[Fallenbagel]

Converted to draft as the title states "WIP". Once it's ready feel free to make this pr ready for review

[bonswouar]

@Fallenbagel Thanks I didn't think about the Draft feature

This is a WIP but it's basically working as I'd expect.
But I could update it with a more specific Monitoring status support if you think it's a good idea?

Only drawback is that if you have lots of Unmonitored movies in Radarr the scan should be slower, as it will request each unmonitored movie in db every time. Let me know if you have some thoughts about this

[bonswouar]

FYI I've been using this for months and it works as expected.
I suspect some other users might need this functionality, couldn't we merge it?

A more complete monitoring status support wouldn't be very useful imo, at least I didn't encounter any use case

[gauthier-th]

I don't think this should be merged if it's only Radarr. Could you implement the same logic for Sonarr seasons?
And shouldn't there be a setting to enable/disable this behavior? You may have unmonitored a movie/tv show but still want to keep it as requested.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[bonswouar]

@gauthier-th I've added the Setting, disabled by default

Also I've tried to add the same behaviour for Sonarr, but I encountered an issue:

• Some (specific) seasons are still shown as "Requested", I don't understand how as I get the new log message "Removing request for ..." for those. Plus I've added a check in processShow() directly, so I really don't see where that could happen in the code. If you've got any clue?

Also, not really related to this issue afaik, but still looks like the same kind of problem:
I've noticed during my debugging that some Seasons are shown as "Available" although they don't contain any file in Sonarr (and are not monitored).
I'd guess it's related to If the season is already marked as available, we force it to stay available (to avoid competing scanners), but I'm really not sure why this condition exists despite the comment (why not at least check if it has any episode instead of relying entirely on the previous status?!)

[bonswouar]

I'll squash the commits when everything's approved

Meanwhile any hint on Sonarr weird behaviour is welcome! I probably missed something, don't know much about the project nor Typescript

[gauthier-th]

It looks like the way things are done are not consistent between Radarr and Sonarr.
Why do you change the status of the Media entity for movies while you remove the SeasonRequest for series?
It may be linked to the issue you experienced.

[gauthier-th]

Why is this change necessary? Isn't the Sonarr scanner job enough?

[bonswouar]

It seems to be necessary. It is part of Sonarr scanner job though!

• At the beginning of the job I check if there is any SeasonRequest and delete it if necessary
• And here I check the Status of the Season, as every Season is parsed and its Status checked/updated, it should set un-monitored season with no file to UNKNOWN (as for Movies)

[gauthier-th]

Also, not really related to this issue afaik, but still looks like the same kind of problem: I've noticed during my debugging that some Seasons are shown as "Available" although they don't contain any file in Sonarr (and are not monitored). I'd guess it's related to If the season is already marked as available, we force it to stay available (to avoid competing scanners), but I'm really not sure why this condition exists despite the comment (why not at least check if it has any episode instead of relying entirely on the previous status?!)

There are several jobs that update the status of a Media: Radarr/Sonarr jobs, and Jellyfin/Emby/Plex jobs, hence the comment about competing jobs.

[bonswouar]

It looks like the way things are done are not consistent between Radarr and Sonarr. Why do you change the status of the Media entity for movies while you remove the SeasonRequest for series? It may be linked to the issue you experienced.

For clarity, there are two potential "problems" with un-monitored medias that I've been trying to fix:

1. Scenario 1
   Nothing is requested. But the movie was originally added (from Radarr directly) with the status monitored. It's been un-monitored later

   • In Jellyseerr it will always be shown as "Requested", which imo is a real issue (it really doesn't match Radarr behaviour, and the user can't know nor do anything about it, will never be able to really request it, etc)
     • => That's my first commit specifically for this problem, for Movies only (and there is no Request in this case, despite the visible "Requested" status)

2. Scenario 2
   Something is requested, but manually un-monitored before it completes. For Movies it's not really a problem imo, as the admin can as easily delete a request from Jellyseerr than un-monitor a Movie from Radarr. But for Shows it becomes more complicated as an admin can't EDIT a Request

   • Thus if for example multiple Seasons of a Show are Requested, but only 1 kept & all the other ones unmonitored from Sonarr, the user won't be able to request again the other ones.
     • => That's the main goal of my second commit for Shows

I can certainly add 1/ for Shows for consistency, but not sure many users automatically import monitored Shows from Sonarr and un-monitor them before they're downloaded. Actually I'm pretty sure that's also what this change does: Season not monitored && no episode = Status UNKNOWN
I hope my explanation & use cases do make sense!

[bonswouar]

There are several jobs that update the status of a Media: Radarr/Sonarr jobs, and Jellyfin/Emby/Plex jobs, hence the comment about competing jobs.

I still don't get the logic, why "If the season is already marked as available, we force it to stay available"?
What if the season is not available anymore??!
The referencing code is:

(season.totalEpisodes === season.episodes && season.episodes > 0) ||
            existingSeason.status === MediaStatus.AVAILABLE

And I don't get why we don't check anything on this second line (i.e existingSeason.status === MediaStatus.AVAILABLE && season.episodes > 0)
But anyway that should be a separate issue I guess as it's not about monitor status

EDIT: Well I did try this simple change, and it seems to fix this issue for one season that was always shown as Available before (although it has been deleted some time ago)

[bonswouar]

@gauthier-th I went with your recommendations, and marked as resolved the comments I was sure about.
I'll let you have a look at my other answers

Not sure why/how, but during my last tests the problem seems fixed!
Although, after running 2 Sonarr scans, I still had:

Removing request for Season X of tmdbId XXXX as it is unmonitored

with the same Season/ID, twice in the log. Which means the first time didn't work, right?

Is there something I should know about async deletion in typescript or something? This seems a bit random

[gauthier-th]

I still don't get the logic, why "If the season is already marked as available, we force it to stay available"?
What if the season is not available anymore??!

There is another job, "Media Availability Sync" that runs and mark the media as unavailable if necessary.

Is there something I should know about async deletion in typescript or something? This seems a bit random

It could come from your forEach loops. For instance in the processUnmonitoredSeason you are using an async function inside a forEach loops, but forEach loops don't wait the end of the async function to run the next item. IMHO It's better to use a for loop to iterate over an array than a forEach, because of this async function concurrency.

Let me review it one more time with the change you made and with your comments in mind.