Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows Jellyseerr to open jellyfin mobile app instead of website #447

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CanardConfit
Copy link

Description

Currently Jellyseerr makes it possible to launch the media on Jellyseer (or plex) on the web but in the case of a mobile or a tablet, there is often an IOS or Android application which can very well be launched from jellyseerr, which avoids to launch the browser.

Urls schemas allow in particular to launch an application instead of a website. To do this, you must replace the http(s) protocol at the beginning of the URL and specify the application that you want to launch (it is often the application package that is used as the schema). Source: https://en.wikipedia.org/wiki/List_of_URI_schemes

In the case of the Jellyfin IOS application (https://github.com/jellyfin/jellyfin-expo), this is org.jellyfin.expo://.

The idea of my pull-request is therefore to allow Jellyseerr to launch an application from its url scheme if it is detected that the user is a mobile.

The Jellyfin app doesn't support Url Schema queries, so it doesn't take the user to the movie page directly... (he ends up in Home) But that may be implemented in the future!

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

--

@CanardConfit
Copy link
Author

Everything works, but I still have to find a way to check if the user has one application or another on his computer... Or if this is not possible, possibly add an option in these settings to know which app throw, like "Prefer to launch Jellyfin iOS instead of the website"

Nobody has any idea?

@ronnoceel
Copy link

ronnoceel commented Dec 19, 2023

One option is to present a popup to users when they press "Open in Jellyfin" that has them choose if they want to open in a browser or in app. If the user selects app, we can assume it's installed. If they select app when it isn't installed, they get an error message (iOS functionality), which I believe in this situation is harmless. This should only be presented to users on iOS.

This is not an ideal solution but it unblocks this PR.

EDIT: related discussion in the iOS app. jellyfin/jellyfin-expo#466

Copy link

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jun 23, 2024
@gauthier-th gauthier-th linked an issue Sep 30, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Cannot merge due to merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Site: 'Play on Jellyfin' directs to Jellyfin app if installed
2 participants