Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notifications): improve discord notifications #1102

Conversation

guillaumearnx
Copy link
Contributor

Description

Added a field in the general notification settings to allow a role to be mentioned in the webhook message via discord notification agent

Screenshot (if UI-related)

image
image

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@gauthier-th
Copy link
Collaborator

Can you please rebase (not merge) on develop and generate translations one more time with pnpm i18n:extract?

Added a field in the general notification settings to allow a role to be mentioned in the webhook
message via discord notification agent
@guillaumearnx guillaumearnx force-pushed the feature-improve-discord-notifications branch from db7d82a to 245ce0c Compare November 15, 2024 11:21
@guillaumearnx
Copy link
Contributor Author

Done. but pnpm i18n:extract didn't change content of en.json file

@gauthier-th gauthier-th changed the title feat: improve discord notifications feat(notifications): improve discord notifications Nov 15, 2024
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@Fallenbagel Fallenbagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gauthier-th gauthier-th merged commit 5c24e79 into Fallenbagel:develop Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants