feat: add more logs to migrations and create a settings backup #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallenbagel
previously approved these changes
Oct 19, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Fallenbagel
requested changes
Oct 19, 2024
server/lib/settings/migrator.ts
Outdated
Comment on lines
62
to
65
| } else if (oldBackup) { | ||
| // no migration occured | ||
| // we save the old backup (to avoid settings.json and settings.old.json being the same) | ||
| fs.writeFileSync(BACKUP_PATH, oldBackup.toString()); |
There was a problem hiding this comment.
Once again, fs.promises.
Suggested change
| } else if (oldBackup) { | |
| // no migration occured | |
| // we save the old backup (to avoid settings.json and settings.old.json being the same) | |
| fs.writeFileSync(BACKUP_PATH, oldBackup.toString()); | |
| await fs.promises.writeFile(SETTINGS_PATH, JSON.stringify(migrated, null, 2)); |
Would it be better to parse this json with type safety?
const fileSaved = JSON.parse(await fs.promises.readFile(SETTINGS_PATH, 'utf-8')) as AllSettings;There was a problem hiding this comment.
We could but I don't really see the point of this since this variable is only used once to be compared after being stringified.
|
We can ignore the broken cypress test. That is because trending api is broken and it's currently showing people instead of media |
|
Fixed some of your comments. |
Fallenbagel
approved these changes
Oct 20, 2024
Fallenbagel
approved these changes
Oct 24, 2024
bonswouar
pushed a commit
to bonswouar/jellyseerr
that referenced
this pull request
Nov 10, 2024
…nbagel#1036) * feat: add more logs to migrations and create a settings backup * fix: avoid backup to be replaced at next startup * fix: resolve review comments * fix: try to fix CodeQL warnings
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed