Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: fix missing kernel routes #17326

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

anlancs
Copy link
Contributor

@anlancs anlancs commented Oct 31, 2024

The rib_update_handle_kernel_route_down_possibility() didn't consider the kernel routes ( blackhole ) without interface. When some other interfaces are down, these kernel routes will be wrongly removed.

The `rib_update_handle_kernel_route_down_possibility()` didn't consider
the kernel routes ( blackhole )  without interface.  When some other
interfaces are down, these kernel routes will be wrongly removed.

Signed-off-by: anlan_cs <[email protected]>
@donaldsharp
Copy link
Member

I think we need a topotest for this case.

@github-actions github-actions bot added size/S and removed size/XS labels Nov 1, 2024
@anlancs
Copy link
Contributor Author

anlancs commented Nov 1, 2024

I think we need a topotest for this case.

Done.

The test verifies that a kernel blackhole route is not affected by
interface's link change.

Signed-off-by: anlan_cs <[email protected]>
@ton31337
Copy link
Member

ton31337 commented Nov 4, 2024

@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

@ton31337 ton31337 added this to the 10.2 milestone Nov 4, 2024
Copy link

mergify bot commented Nov 4, 2024

backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants