Fix issue #36 #37
Merged
Fix issue #36 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removed code overwrites some properties for whatever reason, in particular, quad_scheme. In TensorElement these two lines were not there at all.
… properly Note: the call to FiniteElementBase.__init__ overrides some properties set by the MixedElement constructor. Essentially the same seems to be done in TensorElement, but more explicitly.
mscroggs
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed code overwrites some properties for whatever reason, in particular, quad_scheme.
In
TensorElementthese two lines were not there at all and I do not think that they are required forVectorElement.