Remove deprecated functionality (attach_operators_from_hash_data). #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecation was introduced 4 months ago (#168). Since all the core objects of UFL is using it (Mesh and FunctionSpace) it means that pytest is throwing tons of deprecation warnings at import: ```python python3 -W error::DeprecationWarning -c "import ufl.Mesh" Traceback (most recent call last): File "<string>", line 1, in <module> File "/root/shared/ufl/__init__.py", line 265, in <module> from ufl.domain import as_domain, AbstractDomain, Mesh, MeshView, TensorProductMesh File "/root/shared/ufl/domain.py", line 190, in <module> class TensorProductMesh(AbstractDomain): File "/root/shared/ufl/core/ufl_type.py", line 56, in attach_operators_from_hash_data warnings.warn("attach_operators_from_hash_data deprecated, please use UFLObject instead.", DeprecationWarning) DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead. ```
|
@mscroggs seems like adding |
mscroggs
deleted the
dokken/remove-deprecated_attach_ufl_object_attributes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation was introduced 4 months ago (#168). Since all the core objects of UFL is using it (Mesh and FunctionSpace) it means that pytest is throwing tons of deprecation warnings at import: