Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix Windows CI #3517

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

WIP: Fix Windows CI #3517

wants to merge 27 commits into from

Conversation

jhale
Copy link
Member

@jhale jhale commented Nov 18, 2024

cl.exe compilation fails referring to issue in ordering.cpp

D:\a\dolfinx\dolfinx\dolfinx\cpp\dolfinx\graph\ordering.cpp(214,15): error C2676: binary '[': '_Ty' does not define this operator or a conversion to a type acceptable to the predefined operator [D:\a\dolfinx\dolfinx\dolfinx\build-dir\dolfinx\dolfinx.vcxproj]
D:\a\dolfinx\dolfinx\dolfinx\cpp\dolfinx\graph\ordering.cpp(214,15): error C2676:         with [D:\a\dolfinx\dolfinx\dolfinx\build-dir\dolfinx\dolfinx.vcxproj]
D:\a\dolfinx\dolfinx\dolfinx\cpp\dolfinx\graph\ordering.cpp(214,15): error C2676:         [ [D:\a\dolfinx\dolfinx\dolfinx\build-dir\dolfinx\dolfinx.vcxproj]
D:\a\dolfinx\dolfinx\dolfinx\cpp\dolfinx\graph\ordering.cpp(214,15): error C2676:             _Ty=std::array<int,2> [D:\a\dolfinx\dolfinx\dolfinx\build-dir\dolfinx\dolfinx.vcxproj]
D:\a\dolfinx\dolfinx\dolfinx\cpp\dolfinx\graph\ordering.cpp(214,15): error C2676:         ] [D:\a\dolfinx\dolfinx\dolfinx\build-dir\dolfinx\dolfinx.vcxproj]

Line 214 is lvp[w][0] = i; where lvp is a std::vector of std::array<int, 2> and w is an int. Looks completely fine to me and compiles in GCC and clang without issue (and, previous versions of cl.exe).

https://github.com/FEniCS/dolfinx/blob/main/cpp/dolfinx/graph/ordering.cpp#L213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant