Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass graph partitioner to mesh::refine #3444

Merged
merged 43 commits into from
Oct 2, 2024
Merged

Conversation

garth-wells
Copy link
Member

@garth-wells garth-wells commented Sep 28, 2024

Initial work by @schnellerhase. See #3443 for issue that this PR highlights (but doesn't fix).

Includes significant documentation improvements explaining how ghosts are handled in refinement. This has also highlighted inconsistencies and limitation which should be fixed in the future.

Supersedes #3362

@garth-wells garth-wells added the enhancement New feature or request label Sep 28, 2024
@garth-wells garth-wells added this to the 0.9.0 milestone Sep 28, 2024
@garth-wells garth-wells marked this pull request as ready for review September 29, 2024 11:52
Copy link
Contributor

@chrisrichardson chrisrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like msh but apart from that, looks fine...

@garth-wells garth-wells added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 2262398 Oct 2, 2024
27 checks passed
@garth-wells garth-wells deleted the garth/refine-partition branch October 2, 2024 07:27
francesco-ballarin added a commit to FEniCS/performance-test that referenced this pull request Nov 3, 2024
github-merge-queue bot pushed a commit to FEniCS/performance-test that referenced this pull request Nov 3, 2024
* Pin versions in CI workflow for release 0.9.0

* Add files generate by cmake to .gitignore

* Bring dolfinx::refinement::refine up to date with dolfinx 0.9.0

Due to changes in
FEniCS/dolfinx#3322
FEniCS/dolfinx#3444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants