-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify refine interface #3322
Unify refine interface #3322
Conversation
ca66a76
to
84a6fa4
Compare
|
59a6661
to
02e7fd3
Compare
"Should probably return a shared_ptr to the new mesh, for consistent interface usage with the external API" - This isn't necessary, as the caller takes ownership. Could you try |
Optional return value seems to work as well, in python this just becomes a |
e269508
to
5bdc17e
Compare
|
5bdc17e
to
c40d4f6
Compare
a45215e
to
02d2bec
Compare
b45d9ba
to
02d2bec
Compare
02d2bec
to
a1d0027
Compare
@schnellerhase could you resolve the merge conflict? |
* Pin versions in CI workflow for release 0.9.0 * Add files generate by cmake to .gitignore * Bring dolfinx::refinement::refine up to date with dolfinx 0.9.0 Due to changes in FEniCS/dolfinx#3322 FEniCS/dolfinx#3444
This PR contains several changes to the refinement routines to facilitate a neater, simpler and combined API to the user.
plaza
routines now usesstd::optional
's as input arguments and thus allows for a single code path. (Previously the cases of uniform and adaptive refinement were treated independently)refinement
namespace and now is also used for configuring the interval refinement.std::optional
as well, to no longer need to rely on an ambiguous empty array check.