Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To allow entry_type would be written or not. #418

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

To allow entry_type would be written or not. #418

wants to merge 2 commits into from

Conversation

RubelMozumder
Copy link
Collaborator

The kwarg wrte_entry_type is used in xrd in nomad_measurement.

Currently, populate_nexus_subsection is being called in a step before running the normaliser function of the schema (ELNXrayDiffraction). So, the entry_type is being written in the populate_nexus_subsection and when nomad sees the attr is filled, nomad does not update the value of the entry_type which would be ELNXrayDiffraction. This is problematic, when the external schema like ELNXrayDiffraction uses a nexus dataconverter in a internal process.

lukaspie
lukaspie approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@lukaspie lukaspie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaspie lukaspie lukaspie approved these changes

@sherjeelshabih sherjeelshabih Awaiting requested review from sherjeelshabih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubelMozumder @lukaspie