fix: add type to avoid params order errors

EyeSeeTea · Jun 4, 2024 · 390ac37 · 390ac37
1 parent 702735f
commit 390ac37
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/src/webapp/pages/analysis/steps/1-outliers/OutliersStep.tsx b/src/webapp/pages/analysis/steps/1-outliers/OutliersStep.tsx
@@ -19,12 +19,12 @@ export const OutliersStep: React.FC<PageStepProps> = React.memo(props => {
     });
 
     const runAnalysis = () => {
-        runAnalysisOutlier(
-            analysis.id,
-            section.id,
-            qualityFilters.threshold,
-            qualityFilters.algorithm
-        );
+        runAnalysisOutlier({
+            algorithm: qualityFilters.algorithm,
+            analysisId: analysis.id,
+            sectionId: section.id,
+            threshold: qualityFilters.threshold,
+        });
     };
 
     if (!analysis) return null;

diff --git a/src/webapp/pages/analysis/steps/1-outliers/useOutliers.ts b/src/webapp/pages/analysis/steps/1-outliers/useOutliers.ts
@@ -30,7 +30,8 @@ export function useAnalysisOutlier(props: UseRunAnalysisProps) {
     const [error, setError] = React.useState<Maybe<string>>(undefined);
 
     const runAnalysisOutlier = React.useCallback(
-        (algorithm: string, analysisId: Id, sectionId: Id, threshold: string) => {
+        (options: RunAnalysisOptionsProps) => {
+            const { sectionId, algorithm, analysisId, threshold } = options;
             setLoading(true);
             compositionRoot.outlier.run
                 .execute({
@@ -61,3 +62,9 @@ export function useAnalysisOutlier(props: UseRunAnalysisProps) {
 }
 
 type UseRunAnalysisProps = { onSucess: (qualityAnalysis: QualityAnalysis) => void };
+type RunAnalysisOptionsProps = {
+    algorithm: string;
+    analysisId: Id;
+    sectionId: Id;
+    threshold: string;
+};