Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add github workflow #49

Merged
merged 5 commits into from
May 24, 2024
Merged

chore: add github workflow #49

merged 5 commits into from
May 24, 2024

Conversation

delemaf
Copy link

@delemaf delemaf commented May 22, 2024 •
edited
Loading

📌 References

📝 Implementation

GitHub workflow added:

  • Setup node [16.14.0]
  • Install yarn
  • Install dependencies
  • Run jest tests
  • Run typescript tests

@delemaf delemaf self-assigned this May 22, 2024
@delemaf delemaf requested a review from MiquelAdell May 22, 2024 08:06
@delemaf delemaf changed the title [Chore] Add GitHub workflow chore: add github workflow May 22, 2024
@delemaf delemaf requested a review from eperedo May 22, 2024 11:38
eperedo
eperedo requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delemaf, code looks good, but not sure why are we removing the pull request template?

@delemaf
Copy link
Author

delemaf commented May 23, 2024 •
edited
Loading

Thanks @delemaf, code looks good, but not sure why are we removing the pull request template?

I though it was just a unused template created by default, I'll re-add it!

@delemaf delemaf requested a review from eperedo May 23, 2024 07:09
@delemaf delemaf added the enhancement New feature or request label May 23, 2024
eperedo
eperedo approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@eperedo eperedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delemaf

@MiquelAdell MiquelAdell merged commit 4886645 into development May 24, 2024
1 check passed
@MiquelAdell MiquelAdell deleted the chore/github-workflow branch May 24, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eperedo eperedo eperedo approved these changes

@MiquelAdell MiquelAdell Awaiting requested review from MiquelAdell

Assignees

@delemaf delemaf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delemaf @eperedo @MiquelAdell