New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wrapped HTTP responses (>= 2.38) #145

Open

tokland wants to merge 6 commits into development from feature/support-wrapped-response

Contributor

tokland commented Apr 15, 2024 •

edited

Loading

Required by https://github.com/EyeSeeTea/central-planning-reporting/pull/293

Starting at 2.38, some POST/PUT endpoints return now a wrapped HTTP response, see https://github.com/dhis2/dhis2-releases/blob/master/releases/2.38/README.md#api

Dynamic and generic workaround: inspect the structure of the response and unwrap if necessary.
Remove all responses that had a wrapper HttpResponse in type. BREAKING CHANGE, but easy to solve, as it's fully typed (just use directly response instead of response.response)
Release beta version.

tokland added 6 commits

April 15, 2024 10:15


          Support wrapped HTTP response (>= 2.38)

a24735b


          Bump version

3050fb6


          Don't return wrapped HttpResponse response

f88e5cc


          Bump version

bcd9a38


          Add nvmrc file

73c035c


          Unwrap individual posts

5f43854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet