Reg test updates: remove old transition model test, update VOFZalDisk #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
haven't tested on GPUs. but given the general lack of coverage, I'd be fine with pushing and then finding out if changes need to be made. |
marchdf
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLT test was set up to test a model that was never merged. A new PR with a new transition model (and accompanying reg test) is in draft.
Updating the solver to hypre in the VOFZalDisk enabled it to pass with no diffs, so that should be an easy thing to change. I think the arguments that I included allow it to be GPU and CPU compatible.