Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balanced buoyancy #1280

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Balanced buoyancy #1280

merged 11 commits into from
Aug 21, 2024

Conversation

wjhorne
Copy link
Contributor

@wjhorne wjhorne commented Aug 6, 2024

@mbkuhn These are the balanced buoyancy changes. I still need to evaluate more solid body cases to ensure that it has fixed everything we saw, but so far it has been good in my testing.

@mbkuhn
Copy link
Contributor

mbkuhn commented Aug 13, 2024

@wjhorne I got it to pass CI, but we should still make sure that the reg tests pass properly and also should turn on the new feature in one of the reg tests, probably VOFDroplet

@mbkuhn
Copy link
Contributor

mbkuhn commented Aug 13, 2024

Reg tests look good. I added the balanced buoyancy option to the VOFDroplet reg test and confirmed that it gets a different result. I will check this with the hybrid cases, and it should be good to go, though we did want another nalu-wind developer to sign off on it as well.

@wjhorne
Copy link
Contributor Author

wjhorne commented Aug 15, 2024

@mbkuhn I will discuss this a bit further, but I introduced a new weighting that should give you much more improvement. Feel free to give it a run if you would like to see the difference. I will also introduce a mask later today that will remove the fixed wall issue I noted yesterday.

@wjhorne
Copy link
Contributor Author

wjhorne commented Aug 19, 2024

@psakievich Do you know anyone that could review this to get it in? Our testing looks good for it

@mbkuhn mbkuhn enabled auto-merge (squash) August 21, 2024 18:26
@mbkuhn mbkuhn merged commit f2a6b5b into Exawind:master Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants