-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balanced buoyancy #1280
Balanced buoyancy #1280
Conversation
@wjhorne I got it to pass CI, but we should still make sure that the reg tests pass properly and also should turn on the new feature in one of the reg tests, probably VOFDroplet |
Reg tests look good. I added the balanced buoyancy option to the VOFDroplet reg test and confirmed that it gets a different result. I will check this with the hybrid cases, and it should be good to go, though we did want another nalu-wind developer to sign off on it as well. |
@mbkuhn I will discuss this a bit further, but I introduced a new weighting that should give you much more improvement. Feel free to give it a run if you would like to see the difference. I will also introduce a mask later today that will remove the fixed wall issue I noted yesterday. |
@psakievich Do you know anyone that could review this to get it in? Our testing looks good for it |
@mbkuhn These are the balanced buoyancy changes. I still need to evaluate more solid body cases to ensure that it has fixed everything we saw, but so far it has been good in my testing.