Fixing Dark mode for SymbolDisplay on WinUI and UWP sample apps #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
prathameshnarkhede
commented
Sep 20, 2024
•
prathameshnarkhede
commented
| WinUI | UWP |
|---|---|
 |
 |
dotMorten
approved these changes
Sep 20, 2024
Comment on lines
-12
to
+11
| <Grid Background="{ThemeResource ApplicationPageBackgroundThemeBrush}"> | ||
| mc:Ignorable="d"> | ||
|
|
||
| <Grid> |
There was a problem hiding this comment.
ApplicationPageBackgroundThemeBrush should adjust to the theme. Did this needed to be removed?
There was a problem hiding this comment.
I tested without this and it looked redundant to apply Background to this Grid as rootFrame have the same effect on the look. So I thought of removing it.
mstefarov
approved these changes
Sep 20, 2024
prathameshnarkhede
deleted the
pratham/symboldisplay-winui-uwp-dark-mode-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.