Build warning fixes

Esri · May 15, 2024 · eb3774f · eb3774f
1 parent 3dd2dce
commit eb3774f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Toolkit/Toolkit.UI.Controls/TimeSlider/TimeSlider.cs b/src/Toolkit/Toolkit.UI.Controls/TimeSlider/TimeSlider.cs
@@ -344,7 +344,7 @@ private Size CalculateTextSize(TextBlock textBlock, string? text = null)
                 textBlock.FontSize, textBlock.Foreground, new NumberSubstitution(), TextFormattingMode.Display, 1);
 #else
             var formattedText = new FormattedText(text ?? textBlock.Text, CultureInfo.CurrentCulture, textBlock.FlowDirection, typeface,
-                textBlock.FontSize, textBlock.Foreground, new NumberSubstitution(), TextFormattingMode.Display);
+                textBlock.FontSize, textBlock.Foreground, new NumberSubstitution(), TextFormattingMode.Display, 96);
 #endif
             return new Size(formattedText.Width, formattedText.Height);
 #endif

diff --git a/src/Toolkit/Toolkit.WinUI/Internal/StringFormatConverter.cs b/src/Toolkit/Toolkit.WinUI/Internal/StringFormatConverter.cs
@@ -27,7 +27,9 @@ namespace Esri.ArcGISRuntime.Toolkit.Internal
     public class StringFormatConverter : IValueConverter
     {
         /// <inheritdoc />
+#pragma warning disable CA1033 // Interface methods should be callable by child types: Solution is to seal the class, but this would be a binary breaking change, so disabling warning instead
         object? IValueConverter.Convert(object? value, Type targetType, object? parameter, string language)
+#pragma warning restore CA1033 // Interface methods should be callable by child types
         {
             if (value != null && parameter is string formatString)
             {