Update: replace simplelogger by logger package / NodeLogger functions separate #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use in log calls; nodelogger functions in separate logger package.
…i / cli packages; CLI RestorePrompt enabled.
…asks once visualizer is closed)
…fter creating new node with same number.
…rs; and warnings also introduced.
…r non-watched nodes; added unit test for watch_default.
EskoDijk
added a commit
that referenced
this pull request
Sep 24, 2024
… separate (#71) * [all] replace simplelogger by logger package; avoid excessive unneeded printf calls in log arguments; nodelogger functions in separate logger package. CLI RestorePrompt is now indirectly called through callback interface. Rename Log level type; added NodeLogger writing of new header after creating new node with same number. * [web] bugfix add constant import * [all] fixes in PostAsync task handling during exit; refactoring runcli / cli packages; cli_test race fix; dispatcher task handling fix (can't handle tasks once visualizer is closed). * [cli][simulation] bugfixes for case of command yielding multiple errors; and warnings also introduced. Fixes in del, watch, unwatch commands. * [pylibs] Added unit tests for del/watch/unwatch non-existing nodes, or non-watched nodes; added unit test for watch_default. * [simulation] expanded node log config info printed
EskoDijk
added a commit
that referenced
this pull request
Sep 24, 2024
… separate (#71) * [all] replace simplelogger by logger package; avoid excessive unneeded printf calls in log arguments; nodelogger functions in separate logger package. CLI RestorePrompt is now indirectly called through callback interface. Rename Log level type; added NodeLogger writing of new header after creating new node with same number. * [web] bugfix add constant import * [all] fixes in PostAsync task handling during exit; refactoring runcli / cli packages; cli_test race fix; dispatcher task handling fix (can't handle tasks once visualizer is closed). * [cli][simulation] bugfixes for case of command yielding multiple errors; and warnings also introduced. Fixes in del, watch, unwatch commands. * [pylibs] Added unit tests for del/watch/unwatch non-existing nodes, or non-watched nodes; added unit test for watch_default. * [simulation] expanded node log config info printed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.