Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Accept timestamps as valid date format for the !remindme command #238

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

sthivaios
Copy link
Contributor

Added support for unix timestamps to the !remindme command, so both relative (2w, 1y...) and timestamps work.

Should solve stuff like this : https://discord.com/channels/150662382874525696/717423310308376596/1303016786358435910.

Hope this deploys otherwise rip cliptok ig.

@Erisa Erisa self-requested a review November 4, 2024 19:37
Commands/Reminders.cs Outdated Show resolved Hide resolved
Commands/Reminders.cs Outdated Show resolved Hide resolved
Commands/Reminders.cs Show resolved Hide resolved
@sthivaios
Copy link
Contributor Author

sthivaios commented Nov 4, 2024

@Erisa Checks if the date is in the past now, and also updated the regex exp and removed that little empty line. So it should be good now.

Copy link
Owner

@Erisa Erisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine now. Thanks for your contribution.

@Erisa Erisa merged commit 1e181de into Erisa:main Nov 4, 2024
1 check passed
FloatingMilkshake added a commit that referenced this pull request Nov 5, 2024
This reverts commits bb00220 and 1e181de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants