Update manifest #95
Update manifest #95
Conversation
Add: - <component type> - <launchable> - <developer> - <update_contact> Change: - <id>: new constraints - <url>: update to https - <screenshot>: follow new constraints
Work done to pass flatpak verification. Patch in [pull request](Enigma-Game/Enigma#95) to Enigma project.
|
Thanks for this PR. Seems good to me. |
| <application> | ||
| <id type="desktop">enigma.desktop</id> | ||
| <component type="desktop-application"> | ||
| <id>org.nongnu.enigma</id> |
There was a problem hiding this comment.
We have an own domain name enigma-game.org. I'd prefer to use this. (Even if it just redirects to nongnu for now.)
There was a problem hiding this comment.
Changing the ID has some consequences though:
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#renaming-id-tag
| </ul> | ||
| </description> | ||
| </release> | ||
| </releases> | ||
| <url type="homepage">http://www.nongnu.org/enigma/</url> | ||
| <url type="homepage">https://www.nongnu.org/enigma/</url> |
There was a problem hiding this comment.
https://enigma-game.org as website
| </screenshot> | ||
| <screenshot> | ||
| <image>https://www.nongnu.org/enigma/images/screenshots/mecke22_2.png</image> | ||
| <caption>Example Level</caption> |
There was a problem hiding this comment.
Please use proper level title (to give credits to the authors).
| <content_rating type="oars-1.1" /> | ||
| <updatecontact>[email protected]</updatecontact> | ||
| </application> | ||
| <developer id="enigma.nongnu.org"> |
There was a problem hiding this comment.
I don't really like to duplicate the list of contributors in yet another place.
But if this is good practice for the metadata, then I'm ok with it. Just make sure it is in sync with what is shown in-game. (Which is the most up-to-date list a think.)
There was a problem hiding this comment.
Hmm, spec seems to say we can have just one name tag (per language):
https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#developer-name
Although the file validates via appstreamcli validate.
|
BTW: After we get this all done, I could add the verification step via website. |
Add:
Change:
This work is done, to fit the new constraints for metainfo of Flatpak.