use ListPeerChannels

[YusukeShimizu]

CLN 24.05 removed channels list from ListPeers response.
The listpeers command in the clightning package to use the listpeerchannels function instead of listpeers.

fixes #304 (comment)

[grubles]

I get the same message in my debug.log whether running master or this PR:

2024-09-11T17:23:36.596Z **BROKEN** plugin-topology: DEPRECATED API USED: listchannels.include_private by \"12/cln:listchannels#130\"

[Impa10r]

this is a bug in CLN 23.08

[wtogami]

Running master branch with d51fa0a locally merged for the past two days.

2024-09-15T00:47:25.078Z DEBUG   plugin-peerswap: 
2024-09-15T00:47:25.078Z DEBUG   plugin-peerswap:  msghandler err: message type not in range
2024-09-15T00:47:25.078Z DEBUG   plugin-peerswap: 
2024-09-15T00:47:25.078Z DEBUG   plugin-peerswap:  msghandler err: message type not in range

Unclear where this is coming from. It happened only twice so far.

[grubles]

@wtogami Those errors have occurred for me since at least April, according to my debug.log. It looks like the chanbackup plugin prints a message right before those errors each time. Examples:

2024-08-05T21:09:48.500Z DEBUG   plugin-chanbackup: datastore succeeded for Saving latestscb           
2024-08-05T21:09:48.503Z DEBUG   plugin-peerswap:                                                      
2024-08-05T21:09:48.503Z DEBUG   plugin-peerswap:  msghandler err: message type not in range           
2024-08-05T21:09:48.503Z DEBUG   plugin-peerswap:                                                      
2024-08-05T21:09:48.503Z DEBUG   plugin-peerswap:  msghandler err: message type not in range  

2024-09-10T17:08:42.250Z DEBUG   plugin-chanbackup: Peer sent bad custom message for chanbackup!       
2024-09-10T17:08:42.253Z DEBUG   plugin-peerswap:                                                      
2024-09-10T17:08:42.253Z DEBUG   plugin-peerswap:  msghandler err: message type not in range           
2024-09-10T17:08:42.253Z DEBUG   plugin-peerswap:                                                      
2024-09-10T17:08:42.253Z DEBUG   plugin-peerswap:  msghandler err: message type not in range 

[Impa10r]

@wtogami Those errors have occurred for me since at least April

#305

[YusukeShimizu]

I am going to close this pr because it is not serving its purpose, but please let me know if there are any problems.

[YusukeShimizu]

I wll summarize the situation:

The plugin-topology: DEPRECATED API USED #314 (comment) will not be fixed by the changes in this Pull Request.
The reason why this is happening is under investigation.
This fix might be related?
ElementsProject/lightning#7652

While the channels field in ListPeers will be removed in version 23.05(rustyrussell/lightning@857a55c) , my understanding is that the peerswap-listpeers does not uses the channels field.

msghandler err: message type not in range #314 (comment) is addressed by #315.

[YusukeShimizu]

ElementsProject/lightning#7652 could be the cause.
peerswap-listpeers has a dependency on listchannels.

If that's the cause, no fix is needed for peerswap, and it should be resolved by updating the cln version.

[wtogami]

https://github.com/ElementsProject/lightning/commits/release-24.08.1/
Confirmed the deprecation warning is fixed in upcoming CLN v24.08.1. Closing.