Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix reckless source paths #7820

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ci: Fix reckless source paths #7820

wants to merge 5 commits into from
+35 −31

Conversation

ShahanaFarooqui
Copy link
Collaborator

Changelog-None.

@ShahanaFarooqui ShahanaFarooqui linked an issue Nov 16, 2024 that may be closed by this pull request
reckless install of python packages broken #7817
Open
@ShahanaFarooqui ShahanaFarooqui marked this pull request as ready for review November 16, 2024 06:18
@ShahanaFarooqui ShahanaFarooqui changed the title ci: Update Python version from 3.8 to 3.10 ci: Fix reckless source paths Nov 16, 2024
rustyrussell
rustyrussell requested changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove cppcheck entirely before these other commits.
  2. Why are the CI updates alongside the fix? They seem independent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyrussell rustyrussell rustyrussell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reckless install of python packages broken
2 participants
@ShahanaFarooqui @rustyrussell