New RPC command listaddresses
#7800
Merged
+609
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
force-pushed
the
rpc-listaddresses
branch
from
02e3f30
to
d3769c1
Compare
michael1011
reviewed
Nov 9, 2024
cdecker
requested changes
Nov 9, 2024
rustyrussell
requested changes
Nov 10, 2024
|
Maybe include https://github.com/rustyrussell/lightning/tree/guilt/remember-keytype as a precursor? Though that's untested (might have broken Elements). Then we need only show address types types actually used, at least from now on! |
ShahanaFarooqui
force-pushed
the
rpc-listaddresses
branch
9 times, most recently
from
7d41a24
to
92be426
Compare
rustyrussell
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Ack 92be426
If we really need those dev fields, I'd rather leave the dev-listaddrs command around, and keep listaddresses clean?
ShahanaFarooqui
force-pushed
the
rpc-listaddresses
branch
2 times, most recently
from
30bb08d
to
e381553
Compare
ShahanaFarooqui
force-pushed
the
rpc-listaddresses
branch
3 times, most recently
from
ba142b8
to
419de06
Compare
onchaind used to make its own txs, but doesn't any more. This parameter is useless. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Both for HTLC txs and the to-self outputs. Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: Wallet: Taproot addresses are used for unilateral-close change addresses.
Signed-off-by: Rusty Russell <[email protected]>
|
Rebased on master with flake fixes, and fixed elements (no P2TR). |
rustyrussell
force-pushed
the
rpc-listaddresses
branch
from
419de06
to
4362fe6
Compare
Changelog-Added: New rpc `listaddresses` to list issued addresses from the node.
Added a new test for listaddresses rpc.
rustyrussell
force-pushed
the
rpc-listaddresses
branch
from
4362fe6
to
d46b4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Added: New rpc
listaddressesto list issued addresses from the node.Closes #7439