Updates, candidate 0.9.1 release #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jgriffiths
commented
Jul 28, 2023
•
jgriffiths
commented
- PSBT and tx fixes and new helpers.
- Docs updates, add readthedocs config for the upcoming mandatory changes
- Bump version for a new release
This allows the caller to differentiate between an invalid PSBT/arguments and whether a given struct is present or not.
Rather than forcing the caller to remove these before setting the tx, ignore them when cloning into the global tx. Note that any global tx in a serialized PSBT v0 must still not contain these tx input elements as this is invalid according to BIP-174. (Strictly speaking, witnesses should never be present in the global tx because it should be serialized without them. An upcoming change adds a test case for this).
Expose this by reusing the PSBT parsing code.
Also adds num_items and length getters.
PSBTv2 has a minimum tx version requirement of 2, in order to support its ability to negotiate locktimes. When upgrading a v0 PSBT to v2, automatically increase the tx version to comply with the v2 spec. This means that code which internally upgrades to v2 for processing, then downgrades to v0 later should either: - Do nothing, and accept that the tx version will always be updated - Reject PSBTs containing a tx version less than 2, or - Save and restore the tx version manually, if they are assured that no v2 tx features are used.
|
utACK 58595e8 with minor nit, code review |
jgriffiths
force-pushed
the
more_updates
branch
from
1f19f1b
to
3d2f0d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.