-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API for refreshing currency exchange rates. #1470
Merged
LukasKorba
merged 2 commits into
Electric-Coin-Company:rust-logging-and-exchange-rates
from
LukasKorba:refresh-rates
Aug 1, 2024
Merged
Update API for refreshing currency exchange rates. #1470
LukasKorba
merged 2 commits into
Electric-Coin-Company:rust-logging-and-exchange-rates
from
LukasKorba:refresh-rates
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKorba
force-pushed
the
refresh-rates
branch
from
July 31, 2024 12:59
9e9622c
to
b66f852
Compare
pacu
approved these changes
Jul 31, 2024
str4d
requested changes
Jul 31, 2024
LukasKorba
force-pushed
the
refresh-rates
branch
from
August 1, 2024 09:04
b66f852
to
6f3c1b6
Compare
LukasKorba
force-pushed
the
refresh-rates
branch
3 times, most recently
from
August 1, 2024 11:28
1c8992f
to
da8aad2
Compare
- API refactored to Combine's CurrentValueSubject refresh-rate - FiatCurrencyResult is now Equatable refresh-rates - cleanup refresh-rates - The API has been refactored to follow the same principles as for state and events. - Review comments addressed refresh-rates - The API has been extended to send a result of the operation, success or failure refresh-rates - bugfix of the try vs try? refresh-rates - reverted the error state Update CHANGELOG.md - changelog updated
LukasKorba
force-pushed
the
refresh-rates
branch
from
August 1, 2024 11:28
da8aad2
to
99c46d0
Compare
str4d
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Co-authored-by: Jack Grigg <[email protected]>
LukasKorba
merged commit Aug 1, 2024
aa0b393
into
Electric-Coin-Company:rust-logging-and-exchange-rates
0 of 2 checks passed
daira
reviewed
Aug 6, 2024
daira
reviewed
Aug 6, 2024
daira
reviewed
Aug 6, 2024
daira
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK with comments.
nuttycom
changed the title
refresh-rates
Update API for refreshing currency exchange rates.
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer