-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1176] Cover Spend before Sync with tests #1212
Merged
LukasKorba
merged 3 commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1176-Cover-Spend-before-Sync-with-tests
Aug 31, 2023
Merged
[#1176] Cover Spend before Sync with tests #1212
LukasKorba
merged 3 commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1176-Cover-Spend-before-Sync-with-tests
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasKorba
force-pushed
the
1176-Cover-Spend-before-Sync-with-tests
branch
from
August 28, 2023 09:02
4ebca9d
to
6f8e7b9
Compare
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Aug 28, 2023
- WIP [Electric-Coin-Company#1176] Cover Spend before Sync with tests - next batch of updates [Electric-Coin-Company#1176] Cover Spend before Sync with tests - last batch of fixes and new tests [Electric-Coin-Company#1176] Cover Spend before Sync with tests - package.resolved updated [Electric-Coin-Company#1176] Cover Spend before Sync with tests (Electric-Coin-Company#1212) - added tests for brand new actions related Spend before Sync - RewindActionTests - UpdateChainTipActionTests - UpdateSubtreeRootsActionTests - ProcessSuggestedScanRangesActionTests
LukasKorba
force-pushed
the
feature/DAG-sync
branch
from
August 29, 2023 08:54
f789fa3
to
f50fc8a
Compare
HonzaR
approved these changes
Aug 30, 2023
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
…d before Sync - the computation of progress changed, the total range is computed, that way it works for any kind of sync algorithm - the progress depends on finished scan action, whenever it processes some blocks, it's counted up - the final progress is a ratio between these new values
- WIP [Electric-Coin-Company#1176] Cover Spend before Sync with tests - next batch of updates [Electric-Coin-Company#1176] Cover Spend before Sync with tests - last batch of fixes and new tests [Electric-Coin-Company#1176] Cover Spend before Sync with tests - package.resolved updated [Electric-Coin-Company#1176] Cover Spend before Sync with tests (Electric-Coin-Company#1212) - added tests for brand new actions related Spend before Sync - RewindActionTests - UpdateChainTipActionTests - UpdateSubtreeRootsActionTests - ProcessSuggestedScanRangesActionTests
LukasKorba
force-pushed
the
1176-Cover-Spend-before-Sync-with-tests
branch
from
August 31, 2023 05:47
6f8e7b9
to
8152dca
Compare
LukasKorba
merged commit Aug 31, 2023
c49400d
into
Electric-Coin-Company:feature/DAG-sync
1 check passed
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Sep 7, 2023
- WIP [Electric-Coin-Company#1176] Cover Spend before Sync with tests - next batch of updates [Electric-Coin-Company#1176] Cover Spend before Sync with tests - last batch of fixes and new tests [Electric-Coin-Company#1176] Cover Spend before Sync with tests - package.resolved updated [Electric-Coin-Company#1176] Cover Spend before Sync with tests (Electric-Coin-Company#1212) - added tests for brand new actions related Spend before Sync - RewindActionTests - UpdateChainTipActionTests - UpdateSubtreeRootsActionTests - ProcessSuggestedScanRangesActionTests
LukasKorba
added a commit
that referenced
this pull request
Sep 7, 2023
- WIP [#1176] Cover Spend before Sync with tests - next batch of updates [#1176] Cover Spend before Sync with tests - last batch of fixes and new tests [#1176] Cover Spend before Sync with tests - package.resolved updated [#1176] Cover Spend before Sync with tests (#1212) - added tests for brand new actions related Spend before Sync - RewindActionTests - UpdateChainTipActionTests - UpdateSubtreeRootsActionTests - ProcessSuggestedScanRangesActionTests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1176
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer