Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1167] Steps 3 & 4 - download chain tip metadata from lightwalletd #1177

Conversation

LukasKorba
Copy link
Collaborator

@LukasKorba LukasKorba commented Aug 1, 2023

Closes #1167
Closes #1169

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.

Author

  • Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
  • Automated tests: Did you add appropriate automated tests for any code changes?
  • Code coverage: Did you check the code coverage report for the automated tests? While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
  • Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
  • Run the app: Did you run the app and try the changes?
  • Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
  • Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

  • Checklist review: Did you go through the code with the Code Review Guidelines checklist?
  • Ad hoc review: Did you perform an ad hoc review? In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
  • Automated tests: Did you review the automated tests?
  • Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
  • How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
  • Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
  • Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@LukasKorba LukasKorba requested review from str4d and HonzaR August 1, 2023 11:33
draft

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- code cleanup after draft

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- added ZcashError for putSaplingSubtreeRoots failure
- cleaned up action

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- demo app config temporarily updated to Nighthawk server

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- file header updated

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174)

- demo app config cleaned up

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174)

- offline tests fixed
@LukasKorba LukasKorba force-pushed the 1167-Step-3---Download-chain-tip-metadata-from-lightwalletd branch from 0db27c4 to 375830c Compare August 1, 2023 11:36
@LukasKorba LukasKorba changed the title 1167 step 3 download chain tip metadata from lightwalletd [#1167] step 3 download chain tip metadata from lightwalletd Aug 1, 2023
@LukasKorba LukasKorba changed the title [#1167] step 3 download chain tip metadata from lightwalletd [#1167] Steps 3 & 4 - download chain tip metadata from lightwalletd Aug 1, 2023
draft

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- code cleanup after draft

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- added ZcashError for putSaplingSubtreeRoots failure
- cleaned up action

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- demo app config temporarily updated to Nighthawk server

[Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd

- file header updated
…m lightwalletd

- update chain tip action added

[Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd

- roots removed from the ActionContext

[Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd

- fallback to linear sync until next step is implemented

[Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd

- offline tests fixed
@LukasKorba LukasKorba force-pushed the 1167-Step-3---Download-chain-tip-metadata-from-lightwalletd branch from 375830c to df1624b Compare August 2, 2023 07:48
@LukasKorba LukasKorba merged commit c8417c8 into Electric-Coin-Company:feature/DAG-sync Aug 2, 2023
1 check passed
@LukasKorba LukasKorba deleted the 1167-Step-3---Download-chain-tip-metadata-from-lightwalletd branch August 31, 2023 05:40
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Apr 8, 2024
- globalDBLock has been removed and replaced with global DBActor
@LukasKorba LukasKorba mentioned this pull request Apr 8, 2024
14 tasks
LukasKorba added a commit to LukasKorba/ZcashLightClientKit that referenced this pull request Apr 9, 2024
- globalDBLock has been removed and replaced with global DBActor

[Electric-Coin-Company#1177] Remove globalDBLock (Electric-Coin-Company#1409)

- linter issues
LukasKorba added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants