-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1167] Steps 3 & 4 - download chain tip metadata from lightwalletd #1177
Merged
LukasKorba
merged 3 commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1167-Step-3---Download-chain-tip-metadata-from-lightwalletd
Aug 2, 2023
Merged
[#1167] Steps 3 & 4 - download chain tip metadata from lightwalletd #1177
LukasKorba
merged 3 commits into
Electric-Coin-Company:feature/DAG-sync
from
LukasKorba:1167-Step-3---Download-chain-tip-metadata-from-lightwalletd
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - demo app config cleaned up [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd (Electric-Coin-Company#1174) - offline tests fixed
LukasKorba
force-pushed
the
1167-Step-3---Download-chain-tip-metadata-from-lightwalletd
branch
from
August 1, 2023 11:36
0db27c4
to
375830c
Compare
LukasKorba
changed the title
1167 step 3 download chain tip metadata from lightwalletd
[#1167] step 3 download chain tip metadata from lightwalletd
Aug 1, 2023
LukasKorba
changed the title
[#1167] step 3 download chain tip metadata from lightwalletd
[#1167] Steps 3 & 4 - download chain tip metadata from lightwalletd
Aug 1, 2023
draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - code cleanup after draft [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - UpdateSubtreeRootsAction added, ensuring the roots are downloaded and stored in the DB [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - added ZcashError for putSaplingSubtreeRoots failure - cleaned up action [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - demo app config temporarily updated to Nighthawk server [Electric-Coin-Company#1165] Step 1 - Download note commitment tree data from lightwalletd - file header updated
…m lightwalletd - update chain tip action added [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - roots removed from the ActionContext [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - fallback to linear sync until next step is implemented [Electric-Coin-Company#1167] Step 3 - Download chain tip metadata from lightwalletd - offline tests fixed
LukasKorba
force-pushed
the
1167-Step-3---Download-chain-tip-metadata-from-lightwalletd
branch
from
August 2, 2023 07:48
375830c
to
df1624b
Compare
HonzaR
approved these changes
Aug 2, 2023
LukasKorba
merged commit Aug 2, 2023
c8417c8
into
Electric-Coin-Company:feature/DAG-sync
1 check passed
LukasKorba
deleted the
1167-Step-3---Download-chain-tip-metadata-from-lightwalletd
branch
August 31, 2023 05:40
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Apr 8, 2024
- globalDBLock has been removed and replaced with global DBActor
14 tasks
LukasKorba
added a commit
to LukasKorba/ZcashLightClientKit
that referenced
this pull request
Apr 9, 2024
- globalDBLock has been removed and replaced with global DBActor [Electric-Coin-Company#1177] Remove globalDBLock (Electric-Coin-Company#1409) - linter issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1167
Closes #1169
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer