EW: Add updated ncdata and bnd_topo files for MPASv8 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issues that were seen when using ncdata with longitudes in the [-pi, pi] range in cases with full physics. This would cause the atmosphere to become unphysical and runs to fail. This change is made just after the longitude values are read to ensure they are correct for the remainder of execution.
NOTE: this is before the 'aux_cam' tests have been run
Previous versions of the lonCell_arr adjustment used an explicit loop. Without this loop, the nCells variable and the routine to fetch it are no longer needed.
Makes code consistent with CAM coding standards: 'All variables of type real must have a specified kind, including literals.'
This commit also extends the comment that was with this code block, includes an if condition so valid values aren't modified, uses kinds and constants (pi) that are already used in the new file, and updates the ChangeLog so the correct file is referenced.
This aligns the files with changes in cam6_4_001 (PR ESCOMP#1028).
Conform to CAM Coding Standards: 'Use symbolic numerical comparison operators (e.g., ==, /=, <, >=) not old character versions (e.g., .eq.).'
The correct file for these physics schemes must include topography.
Enable no-topography, idealized test cases with the mpas dycore when running 58L or 93L on 480, 120, 60, and 30km grids.
NOTE: these files also support running with analytic_ic.
Duplicates an entry to ensure that the following two files are used together: - mpasa120_L32_topo_coords_c240508.nc - mpasa120_gmted2010_modis_bedmachine_nc3000_Laplace0100_noleak_20240507.nc Matches the physics specification on new real-data ICs, so the correct *_20240507.nc bnd_topo files are used with them.
Remove old L32 real-data files and all physics specififiers from new real-data files. The old mpasa bnd_topo is similarly replaced. One entry with the old mpasa120 bnd_topo file remains, it is still used by the mpas120km.waccm_fulltopo_c220818.nc ncdata. Specifiers are used to match these entries.
The mpasa120km.waccm_fulltopo_c220818.nc was the last file using mpas_120_nc3000_Co060_Fi001_MulG_PF_Nsw042_c200921.nc, allowing it to be removed.
ESCOMP#1095) These changes address run-time failures that were seen when using MPAS ncdata with longitudes in the [-pi, pi] range in cases with non-simple physics. The atmospheric state would become unphysical and fail.
gdicker1
added
enhancement
gdicker1
changed the title
gdicker1
force-pushed
the
add_v8mpasfiles_eworg2
branch
from
1fa669a
to
937335b
Compare
This was referenced Sep 11, 2024
Bring in dev changes from EarthWorksOrg/CAM
These include:
- mpasa15 32L, 58L, 93L notopo files
- cami (real-data) input files for product {mpasa60, mpasa30, mpasa15 } x {32L, 58L, 93L}
- mpasa60, mpasa30, mpasa15 bnd_topo files.
gdicker1
force-pushed
the
add_v8mpasfiles_eworg2
branch
from
2a7cdbe
to
2bce233
Compare
gdicker1
changed the title
This fixes intel and gnu builds of CHAOS2000dev compset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in similar changes to those added to the upstream. See linked PR for more information.
ESCOMP#1029
This PR will extend the upstream changes to also add 15 EarthWorks-specifc files1:
These changes will fix EarthWorks Issue #55
Footnotes
PR will remain in draft until these files are added to the PR branch ↩