Restart at eor #31
Open
Restart at eor #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvertens
suggested changes
Oct 25, 2024
model/src/wav_shr_mod.F90
Outdated
| update_nextalarm = .true. | ||
| ! call ESMF_ClockGet(clock, TimeStep=AlarmInterval, rc=rc) |
model/src/wav_shr_mod.F90
Outdated
| character(len=CS) :: cvalue | ||
| integer :: comp_dt ! coupling interval of component | ||
| integer, parameter :: ncomps = 8 | ||
| character(len=3),parameter :: compname(ncomps) = (/"atm", "lnd", "ice", "ocn","glc","rof", "wav", "esp"/) |
There was a problem hiding this comment.
Why is this routine in wav share code and not in the general share code? I thought there was actually a routine now in share that could deal with this.
alperaltuntas
approved these changes
Oct 29, 2024
|
I have addressed her comment, and tested the change. I will push it back now. |
mvertens
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Adds support for cesm write_restart_at_endofrun
Description
Denise Worthen may want to review. The stop and restart alarm initialization order needs to be reversed this is in support of setting a restart alarm based on the stop time. A new function get_minimum_time is needed in wav_shr_mod to correct timestamp errors when using _OPTION=nsteps.
Issue(s) addressed
Commit Message
The CESM options REST_OPTION=nsteps, STOP_OPTION=nsteps and HIST_OPTION=nsteps were not properly set by WW3. The component model needs to know the minimum model coupling time in order to correctly set this option.
Check list
Testing