cam6_4_034: Add missing total energy in physics state from dycore in snapshots and cleanup total water #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
approved these changes
Sep 5, 2024
|
@nusbaume - since the changes morphed beyond snapshot code, I am adding you to the reviewer list as I have not reviewed the other changes |
jimmielin
changed the title
|
Thanks @cacraigucar, apologies for repurposing the existing branch/PR. I've updated the title. Changelog update will follow shortly. |
This was referenced Sep 6, 2024
…hys, dyn snapshot fields. Signed-off-by: Haipeng Lin <[email protected]>
…en physics and dycore
jimmielin
force-pushed
the
hplin/fix_total_energy_snapshots
branch
from
ceabf1a
to
1ecca08
Compare
|
Changes rebased on newest |
nusbaume
approved these changes
Sep 17, 2024
cacraigucar
changed the title
jimmielin
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Sep 26, 2024
…date standard names (#296) Companion issue in CAM: ESCOMP/CAM#1141 Companion PR in CAM: ESCOMP/CAM#1142 this PR in CAM will update snapshots with new variables. Updates to CAM-SIMA: - read ncdata variables te_ini_phys, te_ini_dyn, te_cur_phys, te_cur_dyn - update to standard names per discussion in ESCOMP/CAM#1141
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1142 from jimmielin/hplin/fix_total_energy_snapshots cam6_4_034: Add missing total energy in physics state from dycore in snapshots and cleanup total water ESCOMP commit: 4c7c062
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1142 from jimmielin/hplin/fix_total_energy_snapshots cam6_4_034: Add missing total energy in physics state from dycore in snapshots and cleanup total water ESCOMP commit: 4c7c062
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Nov 8, 2024
Merge pull request ESCOMP#1142 from jimmielin/hplin/fix_total_energy_snapshots cam6_4_034: Add missing total energy in physics state from dycore in snapshots and cleanup total water ESCOMP commit: 4c7c062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1141
Saves second dimension (dycore formula) of total energy and total water initial and current condition.
Companion PR in CAM-SIMA to read updated snapshot file and updates to standard names:
ESCOMP/CAM-SIMA#296