-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_038: GEOS-Chem 14.4 and dependencies #1093
Conversation
ACOM (e.g., @tilmes, Doug Kinnison) think Cloud-J would be a great option to include in CESM3, as an alternative to TUV-x for now. |
90635b6
to
0462961
Compare
The tests failed due to git-fleximod errors. I am looking into them now.
|
This issue is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I have a few questions and change requests.
test/system/TR8.sh
needs to be updated to skip over the new submodules.
Have you ran the aux_cam regression test suite to ensure that these changes to mo_neu_wetdep do not affect CAMChem or WACCM?
Suggested changes to
|
When I run submit aux_cam test suite I get a lot of errors because I am on derecho instead of izumi. Is it still useful for me to test with it? |
This is how I submit the tests on derecho:
|
I now have lots of tests in ~elundgren/scratch. Could you tell me what tests to look at? Or do you run a script to evaluate all of them at once? |
To get a summary of the test results try thist:
I see that you have a izumi tests as well as derecho tests. You must be launching the tests differntly. When I use the test_driver.sh script it creates an aux_cam sub dir under my scratch. For an example, see
|
@fvitt, here are the aux_cam test results. Let me know if we should be concerned about any of these. I am not sure why some are still pending given this was done last week.
|
Good to know. I submitted via this since it is what I use for |
Using the example that Francis provided, you can add a flag In summary:
The |
Thanks for the tips @cacraigucar. @fvitt, could you give me an update on where this PR stands. I see there are now conflicts due to new commits in cam_development. I can rebase and test again next week. Otherwise there are no remaining updates to add since I believe I addressed all of your comments. I am not sure about the test results above for non-GEOS-Chem runs and will need help deciphering those. |
@fvitt, I have rebased locally and will run tests on derecho and izumi prior to pushing. However, when I try to use test_driver.sh I get this error: Should I set this to the GEOS-Chem project or to some other account? |
Yes, use the GEOS-Chem project number. |
@fvitt, now I am getting
|
@lizziel
|
Still not working...
|
Did you try this on izumi? |
Ah, I did not notice you switched to izumi. I am trying to run tests using test_driver.sh on derecho prior to pushing. I do not have the code on izumi right now. |
67e9826
to
53b15b1
Compare
- Update GEOS-Chem and dependencies in .gitmodules - Remove obsolete Externals files Signed-off-by: Lizzie Lundgren <[email protected]> Update changelog Update GEOS-Chem to version 14.4.2 release tag Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
This commit also moves the location of the GEOS-Chem compsets within the config_compsets.xml file to be by their corresponding cam-chem compset. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
…tted Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
… def Including %NUDG after %HEMCO rather than before it results in the omission of the nudging_nl namelist in atm_in. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Updates for compatibility with GEOS-Chem are now merged into HETP and released as tag HETPv1.1. This removes the prior need to use the fork in the GEOS-Chem github organization. This is a zero diff update. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
This update is a zero diff update. The url may change again in the future once an institutional github is available for Environment and Climate Change Canada. In the meantime the GEOS-Chem fork will be used. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
ba48ea6
to
136322b
Compare
This PR is now rebased on cam6_4_037 and the changelog is updated. |
@lizziel |
@fvitt, that is right. |
Although @jimmielin told me occasionally FCSD_HCO has differences. If you see this then it is safe to say it is a pre-existing issue. |
Merge pull request ESCOMP#1093 from geoschem/feature/geoschem_14.4 cam6_4_038: GEOS-Chem 14.4 and dependencies ESCOMP commit: 1abe4a8
Merge pull request ESCOMP#1093 from geoschem/feature/geoschem_14.4 cam6_4_038: GEOS-Chem 14.4 and dependencies ESCOMP commit: 1abe4a8
Merge pull request ESCOMP#1093 from geoschem/feature/geoschem_14.4 cam6_4_038: GEOS-Chem 14.4 and dependencies ESCOMP commit: 1abe4a8
This PR updates GEOS-Chem from version 14.1.2 to 14.4.3 It also includes updating HEMCO_CESM to 2.0.0 and HEMCO to 3.9.0. In addition, there are two new submodules in CAM: (1) Cloud-J 7.7.3, now used in GEOS-Chem for computing J-values, and (2) HETP v1.1, an improved ISORROPIA for aerosol thermodynamics in GEOS-Chem.
This PR supercedes #996 which was updating to an older version of GEOS-Chem.
Closes #959