Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven download plugin unpackWhenChanged fixes #224

Merged
merged 1 commit into from
Oct 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,6 @@ jobs:
mvn --batch-mode
-Dgcf.skipInstallHooks=true
-Dmaven.test.redirectTestOutputToFile=true
-Ddownload.unpack=true
-Ddownload.unpackWhenChanged=false
clean verify
2 changes: 1 addition & 1 deletion PROGRAMMER_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ ERDDAP™ uses Maven to load code dependencies as well as some static reference

- [erddapContent.zip](https://github.com/ERDDAP/erddapContent/releases/download/content1.0.0/erddapContent.zip) (version 1.0.0, 20333 bytes, MD5=2B8D2A5AE5ED73E3A42B529C168C60B5, dated 2024-10-14) and unzip it into _tomcat_, creating _tomcat_/content/erddap .

NOTE: By default Maven will cache static reference and test data archive downloads and only extract them when a new version is downloaded. To skip downloading entirely, you may set the `skipResourceDownload` and/or `skipTestResourceDownload` properties to Maven (e.g. `mvn -DskipResourceDownload package`). To force extraction, set `-Ddownload.unpack`.
NOTE: By default Maven will cache static reference and test data archive downloads and only extract them when a new version is downloaded. To skip downloading entirely, you may set the `skipResourceDownload` and/or `skipTestResourceDownload` properties to Maven (e.g. `mvn -DskipResourceDownload package`). To force extraction, set `-Ddownload.unpack=true` and `-Ddownload.unpackWhenChanged=false`.

- ERDDAP™ and its subcomponents have very liberal, open-source [licenses](https://erddap.github.io/setup.html#license), so you can use and modify the source code for any purpose, for-profit or not-for-profit. Note that ERDDAP™ and many subcomponents have licenses that require that you acknowledge the source of the code that you are using. See [Credits](https://erddap.github.io/setup.html#credits). Whether required or not, it is just good form to acknowledge all of these contributors.

Expand Down
15 changes: 8 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
<test.resources.version>test1.04</test.resources.version>
<jettyVersion>12.0.14</jettyVersion>
<error-prone.version>2.27.0</error-prone.version>
<download.unpackWhenChanged>true</download.unpackWhenChanged>
</properties>

<repositories>
Expand Down Expand Up @@ -269,7 +270,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/erddapContent/releases/download/${erddapcontent.download.version}/erddapContent.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}</outputDirectory>
<skip>${skipResourceDownload}</skip>
</configuration>
Expand All @@ -282,7 +283,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/ERDDAPRefFiles/releases/download/${erddapreffiles.download.version}/etopo1_ice_g_i2.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/WEB-INF/ref/</outputDirectory>
<skip>${skipResourceDownload}</skip>
</configuration>
Expand All @@ -295,7 +296,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/ERDDAPRefFiles/releases/download/${erddapreffiles.download.version}/ref_files.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/WEB-INF/ref/</outputDirectory>
<skip>${skipResourceDownload}</skip>
</configuration>
Expand All @@ -309,7 +310,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/erddapTest/releases/download/${test.resources.version}/data.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/test-data</outputDirectory>
<skip>${skipTestResourceDownload}</skip>
</configuration>
Expand All @@ -322,7 +323,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/erddapTest/releases/download/${test.resources.version}/largeFiles.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/test-data</outputDirectory>
<skip>${skipTestResourceDownload}</skip>
</configuration>
Expand All @@ -335,7 +336,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/erddapTest/releases/download/${test.resources.version}/largePoints.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/test-data</outputDirectory>
<skip>${skipTestResourceDownload}</skip>
</configuration>
Expand All @@ -348,7 +349,7 @@
</goals>
<configuration>
<url>https://github.com/ERDDAP/erddapTest/releases/download/${test.resources.version}/largeSatellite.zip</url>
<unpackWhenChanged>true</unpackWhenChanged>
<unpackWhenChanged>${download.unpackWhenChanged}</unpackWhenChanged>
<outputDirectory>${project.basedir}/test-data</outputDirectory>
<skip>${skipTestResourceDownload}</skip>
</configuration>
Expand Down
Loading